Removed nmi_addr_i; removed USE_DEPRECATED_FEATURE_SET parameter #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjan Bink <[email protected]>
Signed-off-by: Arjan Bink <[email protected]>
Silabs-ArjanB
added
the
Component:RTL
silabs-oysteink
requested changes
Apr 20, 2022
bhv/cv32e40x_wrapper.sv
Outdated
| @@ -338,7 +337,7 @@ module cv32e40x_wrapper | |||
| rvfi_sva(.irq_ack(core_i.irq_ack), | |||
| .dbg_ack(core_i.dbg_ack), | |||
| .ebreak_in_wb_i(core_i.controller_i.controller_fsm_i.ebreak_in_wb), | |||
| .nmi_addr_i(core_i.nmi_addr_i), | |||
| .mtvec_addr_i(core_i.mtvt_addr), | |||
There was a problem hiding this comment.
This seems wrong, should it be connected to core_i.mtvec_addr?
Signed-off-by: Arjan Bink <[email protected]>
silabs-oysteink
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEC equivalent if USE_DEPRECATED_FEATURE_SET = 0.
Did not run assertion check flow as that is currently not compiling.
Note that the a_rvfi_nmip_nmi_handler was fixed as well. It was not correct for either setting of USE_DEPRECATED_FEATURE_SET. I don't know why these assertions are excluded from formal runs (I will check with Halfdan).
Signed-off-by: Arjan Bink [email protected]