Bugfixes after running formal #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disregard clic pointers in decoder assertion for onehot unit enables (may be changed to give better checking later) Some commented out code for the next bugfix (CLIC pointer + debug single step) Signed-off-by: Oystein Knauserud <[email protected]>
Basic mode: No design assertions fail, four has unmet covers (CLIC related) CLIC mode : No design assertions fail, no unmet covers. Signed-off-by: Oystein Knauserud <[email protected]>
silabs-oysteink
added
the
Component:RTL
parameters to the respective sva module to exclude CLIC specifi assertions when CLIC is not enabled. Signed-off-by: Oystein Knauserud <[email protected]>
Silabs-ArjanB
approved these changes
Apr 25, 2022
| a_clicv_next_pc_set: | ||
| assert property (@(posedge clk) disable iff (!rst_n) | ||
| (ctrl_fsm_o.pc_set && (ctrl_fsm_o.pc_mux == PC_TRAP_CLICV)) | ||
| |=> !ctrl_fsm_o.pc_set until (ctrl_fsm_o.pc_set && ((ctrl_fsm_o.pc_mux == PC_TRAP_CLICV_TGT) || |
There was a problem hiding this comment.
It seems a little inconsistent: Here and in th CS register file single stepping debug entry is not allowed, but in the controller FSM it is actually implemented. Okay for now though as there is a todo on handling of single stepping for pointer fetches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLIC SHV + single stepping should now work.
Disabled trigger matches for CLIC pointers (awaiting spec change for CLIC in this regards)
Various other small bugfixes and assertion updates.