Speeding up decoder #516
Merged
Speeding up decoder #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjan Bink <[email protected]>
Silabs-ArjanB
added
the
Component:RTL
Silabs-ArjanB
requested review from
silabs-oysteink
and removed request for
silabs-oysteink
Silabs-ArjanB
added
Status:Do-not-merge
silabs-oysteink
requested changes
Apr 26, 2022
| // Check that branch/jump related signals can be used from I decoder directly (bypassing other decoders) | ||
| a_branch_jump_decode : | ||
| assert property (@(posedge clk) disable iff (!rst_n) | ||
| 1'b1 |-> ( |
There was a problem hiding this comment.
This assert is failing formal when the instruction is an illegal compressed instruction. Assert can be made passing by changing "1'b1 |->" to "!if_id_pipe.illegal_c_insn |->".
There was a problem hiding this comment.
Fixed the RTL so that these assertions now pass.
…d compressed instructions Signed-off-by: Arjan Bink <[email protected]>
silabs-oysteink
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEC clean (trade off readability vs. speed/gates)
Did not try out newly added assertions
Signed-off-by: Arjan Bink [email protected]