Added assertions for LSU split_q and trigger_match_0_i #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppressing LSU valid_0_i on trigger_match_0_i could cause the split_q flag to reset to zero before the last part of an LSU was allowed to go from EX to WB. This could cause an address change and change of the trigger match value. Updated setting/resetting of split_q to take trigger matches into account. Added assertions to check that split_q is always 0 when a new LSU instruction enters the EX stage and that the trigger match flag is stable while an LSU instruction remains in EX. Signed-off-by: Oystein Knauserud <[email protected]> ed files:
…l be issued later. Signed-off-by: Oystein Knauserud <[email protected]> er match flag is stable while an LSU instruction remains in EX. Signed-off-by: Oystein Knauserud <[email protected]> ed files:
silabs-oysteink
changed the title
Silabs-ArjanB
added
the
Component:RTL
Silabs-ArjanB
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split_q should always be 0 when a new LSU instruction enters EX (currently passes)
trigger_match_0_i should remain stable when an LSU instruction is in EX but not yet allowed to progress to WB (currently fails)