Single step and debug cause cleanup #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g_single_step. Updated setting of debug_cause_n, all possible causes are now in the priority (0.13.2, will be updated for 1.0.0). When all casues are set, some code cleanup faning into kill_wb from the DEBUG_TAKEN state was possible. Updaed RVFI to account for the possibility of have pending_single_step active at the same time as there can be pending async or sync debug reasons. Signed-off-by: Oystein Knauserud <[email protected]>
silabs-oysteink
added
the
Component:RTL
|
Partly fixes issue #345. |
| assign debug_cause_n = (trigger_match_in_wb || etrigger_wb_i) ? DBG_CAUSE_TRIGGER : // Etrigger will enter DEBUG_TAKEN as a single step (no halting), but kill pipeline as non-stepping entries. | ||
| (ebreak_in_wb && dcsr_i.ebreakm && !debug_mode_q) ? DBG_CAUSE_EBREAK : // Ebreak during machine mode | ||
| (ebreak_in_wb && debug_mode_q) ? DBG_CAUSE_EBREAK : // Ebreak during debug mode | ||
| (pending_async_debug && async_debug_allowed) ? DBG_CAUSE_HALTREQ : |
There was a problem hiding this comment.
I had expected debug_cause_q here, but this works as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed dependency on other pending debug causes when setting 'pending_single_step.
Updated setting of debug_cause_n, all possible causes are now in the priority (0.13.2, will be updated for 1.0.0). When all casues are set, some code cleanup faning into kill_wb from the DEBUG_TAKEN state was possible.
Updaed RVFI to account for the possibility of have pending_single_step active at the same time as there can be pending async or sync debug reasons.
Signed-off-by: Oystein Knauserud [email protected]