PUSH/POP not allowed outside of 'main' PMA regions #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t configured as 'main'. Tracking push/pop with a bit in instr_meta, propagating to the LSU MPU. Instruction side prefetches are not part of a sequence and the IF stage MPU has this bit tied to zero. Signed-off-by: Oystein Knauserud <[email protected]>
silabs-oysteink
added
the
Component:RTL
Silabs-ArjanB
requested changes
Jan 30, 2023
rtl/cv32e40x_sequencer.sv
Outdated
| @@ -170,6 +172,7 @@ module cv32e40x_sequencer import cv32e40x_pkg::*; | |||
| end | |||
| end | |||
| 3'b110: begin | |||
| seq_pushpop_o = 1'b1; | |||
There was a problem hiding this comment.
I prefer if illegal isntructions are excluded from having seq_push_pop_o set to 1. Same remark for line 191
There was a problem hiding this comment.
Agreed, fixed.
…list values). Signed-off-by: Oystein Knauserud <[email protected]>
Silabs-ArjanB
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.