Not flagging exception for ebreak if dcsr.ebreakm==1. #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not SEC clean as there is a difference when an exception trigger is enabled. Old cold would get an exception trigger that caused debug entry while new code would not get an exception and enter debug with cause=ebreak. Signed-off-by: Oystein Knauserud <[email protected]>
silabs-oysteink
added
the
Component:RTL
silabs-oysteink
commented
Feb 3, 2023
| ex_wb_pipe_i.instr.bus_resp.err || | ||
| ex_wb_pipe_i.illegal_insn || | ||
| (ex_wb_pipe_i.sys_en && ex_wb_pipe_i.sys_ecall_insn) || | ||
| (ex_wb_pipe_i.sys_en && ex_wb_pipe_i.sys_ebrk_insn && !dcsr_i.ebreakm && !debug_mode_q) || |
There was a problem hiding this comment.
First change. This was not SEC clean as it caused a difference on etrigger vs ebreak.
silabs-oysteink
commented
Feb 3, 2023
| ex_wb_pipe_i.instr.bus_resp.err ? EXC_CAUSE_INSTR_BUS_FAULT : | ||
| ex_wb_pipe_i.illegal_insn ? EXC_CAUSE_ILLEGAL_INSN : | ||
| (ex_wb_pipe_i.sys_en && ex_wb_pipe_i.sys_ecall_insn) ? EXC_CAUSE_ECALL_MMODE : | ||
| (ex_wb_pipe_i.sys_en && ex_wb_pipe_i.sys_ebrk_insn && !dcsr_i.ebreakm && !debug_mode_q) ? EXC_CAUSE_BREAKPOINT : |
There was a problem hiding this comment.
dcsr.ebreakm part of second change, along with the minstret counter change on line 562. SEC clean with correct OBI protocol. Third change was the debug_mode_q on line 348, that was SEC clean.
Silabs-ArjanB
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not SEC clean as there is a difference when an exception trigger is enabled. Old cold would get an exception trigger that caused debug entry while new code would not get an exception and enter debug with cause=ebreak.
Signed-off-by: Oystein Knauserud [email protected]