Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameter DEBUG_TRIGGER_EN. Add explicit parameter types. #826

Merged
merged 2 commits into from
Apr 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions rtl/cv32e40x_decoder.sv
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ module cv32e40x_decoder import cv32e40x_pkg::*;
parameter a_ext_e A_EXT = A_NONE,
parameter b_ext_e B_EXT = B_NONE,
parameter m_ext_e M_EXT = M,
parameter DEBUG_TRIGGER_EN = 1,
parameter bit CLIC = 1
)
(
Expand Down Expand Up @@ -142,7 +141,6 @@ module cv32e40x_decoder import cv32e40x_pkg::*;
// RV32I Base instruction set decoder
cv32e40x_i_decoder
#(
.DEBUG_TRIGGER_EN (DEBUG_TRIGGER_EN),
.CLIC (CLIC )
)
i_decoder_i
Expand Down
2 changes: 1 addition & 1 deletion rtl/cv32e40x_ff_one.sv
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

module cv32e40x_ff_one
#(
parameter LEN = 32
parameter int unsigned LEN = 32
)
(
input logic [LEN-1:0] in_i,
Expand Down
1 change: 0 additions & 1 deletion rtl/cv32e40x_i_decoder.sv
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@

module cv32e40x_i_decoder import cv32e40x_pkg::*;
#(
parameter DEBUG_TRIGGER_EN = 1,
parameter bit CLIC = 1
)
(
Expand Down
2 changes: 0 additions & 2 deletions rtl/cv32e40x_id_stage.sv
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ module cv32e40x_id_stage import cv32e40x_pkg::*;
parameter b_ext_e B_EXT = B_NONE,
parameter m_ext_e M_EXT = M,
parameter bit X_EXT = 0,
parameter DEBUG_TRIGGER_EN = 1,
parameter int unsigned REGFILE_NUM_READ_PORTS = 2,
parameter bit CLIC = 1
)
Expand Down Expand Up @@ -422,7 +421,6 @@ module cv32e40x_id_stage import cv32e40x_pkg::*;
.A_EXT ( A_EXT ),
.B_EXT ( B_EXT ),
.M_EXT ( M_EXT ),
.DEBUG_TRIGGER_EN ( DEBUG_TRIGGER_EN ),
.CLIC ( CLIC )
)
decoder_i
Expand Down
2 changes: 1 addition & 1 deletion rtl/cv32e40x_lsu_response_filter.sv
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

module cv32e40x_lsu_response_filter
import cv32e40x_pkg::*;
#(parameter DEPTH = 2)
#(parameter int unsigned DEPTH = 2)
(
// clock and reset
input logic clk,
Expand Down
8 changes: 4 additions & 4 deletions sva/cv32e40x_load_store_unit_sva.sv
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ module cv32e40x_load_store_unit_sva
import uvm_pkg::*;
import cv32e40x_pkg::*;
#(
parameter bit X_EXT = 0,
parameter DEPTH = 0,
parameter bit DEBUG = 1,
parameter a_ext_e A_EXT = A_NONE
parameter bit X_EXT = 0,
parameter int unsigned DEPTH = 0,
parameter bit DEBUG = 1,
parameter a_ext_e A_EXT = A_NONE
)
(input logic clk,
input logic rst_n,
Expand Down
2 changes: 1 addition & 1 deletion sva/cv32e40x_lsu_response_filter_sva.sv
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
module cv32e40x_lsu_response_filter_sva
import cv32e40x_pkg::*;
import uvm_pkg::*;
#(parameter DEPTH = 2)
#(parameter int unsigned DEPTH = 2)
(input logic clk,
input logic rst_n,

Expand Down
2 changes: 1 addition & 1 deletion sva/cv32e40x_prefetch_unit_sva.sv
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
module cv32e40x_prefetch_unit_sva import cv32e40x_pkg::*;
import uvm_pkg::*;
#(
parameter CLIC = 1'b0
parameter bit CLIC = 1'b0
)
(
input logic clk,
Expand Down