Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed three TODO's in the pkg file. #906

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Removed three TODO's in the pkg file. #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions rtl/include/cv32e40x_pkg.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ package cv32e40x_pkg;

parameter ALU_OP_WIDTH = 6;

// TODO:low Could a smarter encoding be used here?

// Note: Certain bits in alu_opcode_e are referred to directly in the ALU:
//
// - Bit 2: Right shift?
Expand All @@ -89,7 +87,6 @@ typedef enum logic [ALU_OP_WIDTH-1:0]
ALU_B_ORN = 6'b101110, // funct3 = 110, zbb
ALU_B_ANDN = 6'b101111, // funct3 = 111, zbb

// Comparisons // todo: comparator operators do not need to be part of ALU operators
ALU_EQ = 6'b010000, // funct3 = 000
ALU_NE = 6'b010001, // funct3 = 001
ALU_SLT = 6'b011010, // funct3 = 010, signed(3)
Expand Down Expand Up @@ -1106,7 +1103,6 @@ typedef struct packed {
} outstanding_t;

// Instruction meta data
// TODO: consider moving other instruction meta data to this struct. e.g. xxx_insn, pc, etc (but don't move stuff here that is specific to one functional unit)
typedef struct packed
{
logic compressed;
Expand Down