Enabling users to upload custom GeoJSON

[Shivamdhar]

Description

• Enables users to upload custom GeoJSON files
• Adds UI elements, API layer and backend connectivity code with OpenSearch cluster and geospatial plugin

Issues Resolved

#1408
Task - Allow users to upload custom vector map

Check List

• New functionality includes testing.

       yarn test:jest src/plugins/region_map/*                                  
       yarn run v1.22.18
       $ node scripts/jest src/plugins/region_map/common src/plugins/region_map/config.ts 
       src/plugins/region_map/opensearch_dashboards.json src/plugins/region_map/package.json 
       src/plugins/region_map/public src/plugins/region_map/server src/plugins/region_map/target
       PASS  src/plugins/region_map/public/region_map_fn.test.js
       PASS  src/plugins/region_map/public/components/empty_prompt.test.tsx
       PASS  src/plugins/region_map/public/components/vector_upload_options.test.tsx
       PASS  src/plugins/region_map/public/components/custom_vector_upload.test.tsx
      
      Test Suites: 4 passed, 4 total
      Tests:       16 passed, 16 total
      Snapshots:   5 passed, 5 total
      Time:        10.499 s
  

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration

       Test Suites: 50 passed, 50 total
       Tests:       5 skipped, 438 passed, 443 total
       Snapshots:   77 passed, 77 total
       Time:        329.189 s
       Ran all test suites.
                │ info [opensearch] cleanup complete
       Done in 332.29s.
      

    • yarn test:ftr

• New functionality has been documented.
  RFC can be accessed here: [RFC] - Upload Custom GeoJSON as vector map geospatial#47

• Commits are signed per the DCO using --signoff

Todo:

• Add unit tests

[VijayanB]

@kavilla From our POV this PR looks good other than some minor feedback. Can you please take a look at it? Thanks.

[tmarkley]

@VijayanB @Shivamdhar the core Dashboards team has expressed some concerns about this approach in the original issue: #1408. Can we discuss the open questions first before proceeding?

[Shivamdhar]

@VijayanB @Shivamdhar the core Dashboards team has expressed some concerns about this approach in the original issue: #1408. Can we discuss the open questions first before proceeding?

Sure Tommy, will jot down the thoughts in that thread by eod. Thanks for taking out time : )

[tmarkley]

Excluding the open conversation about the approach itself, we need test coverage before this is merged. There are no new tests here. If you need help determining how to implement tests, please let us know.

[Shivamdhar]

Excluding the open conversation about the approach itself, we need test coverage before this is merged. There are no new tests here. If you need help determining how to implement tests, please let us know.

Yes, I'm on it. I'll be adding tests to the PR as I'm getting to learn the different testing strategies on this side as well. Currently, working on adding snapshot tests. Will keep the PR updated with the test cases as and when I write them.

[tmarkley]

Blocking this until tests are added. Take a look at our guide for Writing Tests and feel free to reach out if you need additional help!

[codecov-commenter]

Codecov Report

Merging #1437 (dec62ce) into main (0afba22) will increase coverage by 0.03%.
The diff coverage is 80.57%.

@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
+ Coverage   68.09%   68.12%   +0.03%     
==========================================
  Files        3072     3078       +6     
  Lines       59033    59175     +142     
  Branches     8928     8950      +22     
==========================================
+ Hits        40199    40314     +115     
- Misses      16647    16668      +21     
- Partials     2187     2193       +6     

Impacted Files	Coverage Δ
src/plugins/region_map/public/services.ts	20.00% <20.00%> (ø)
...on_map/public/components/vector_upload_options.tsx	85.00% <85.00%> (ø)
src/plugins/region_map/common/constants/shared.ts	100.00% <100.00%> (ø)
...ion_map/public/components/custom_vector_upload.tsx	100.00% <100.00%> (ø)
...gins/region_map/public/components/empty_prompt.tsx	100.00% <100.00%> (ø)
src/plugins/region_map/public/region_map_fn.js	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0afba22...dec62ce. Read the comment docs.

[Shivamdhar]

We have decided to move the component (Import custom map tab) out from region map and make it part of the dashboards-maps plugin. Closing this PR in favor of opensearch-project/dashboards-maps#7.

Thank you all for you suggestions and guidance.