Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep aggregation in Calcite consistent with current PPL behavior #3405

Open
wants to merge 4 commits into
base: feature/calcite-engine
Choose a base branch
from

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Mar 9, 2025

Description

  1. Keep aggregation in Calcite consistent with current PPL behavior. Details in [Enhancement] Keep aggregation results in Calcite consistent with current PPL behavior #3403
  2. Return null if all records are null with group-by. see [BUG] SUM and AVG should return NULL if all the records are NULL #3404
  3. Add ppl rename command with Calcite.

All unit tests in ppl/src/test/java/org/opensearch/sql/ppl/calcite succeed in local
./gradlew :integ-test:integTest --tests '*Calcite*IT' passed in local

Related Issues

Resolves #3403, #3404

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lantao Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calcite calcite migration releated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant