CCXDEV-14850: insights add storage spec

[opokornyy]

This PR adds fields to the DataGather and InsightsDataGather CRDs, allowing users to specify the Persistent Volume spec for on-demand gathering jobs.

[openshift-ci]

Hello @opokornyy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@opokornyy: This pull request references CCXDEV-14850 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@opokornyy: This pull request references CCXDEV-14850 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This PR adds fields to the DataGather and InsightsDataGather CRDs, allowing users to specify the Persistent Volume spec for on-demand gathering jobs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

One additional comment after looking over the most recent changes. Other than that I think this looks good.

[opokornyy]

One additional comment after looking over the most recent changes. Other than that I think this looks good.

What should I do about the error in tests? It adds a new required field, but it is wrapped in an optional struct, so IMO it should be fine right?

ERROR: NoNewRequiredFields: crd/datagathers.insights.openshift.io version/v1alpha1 field/^.spec.storageSpec.persistentVolumeClaimName is new and may not be required

[everettraven]

One additional comment after looking over the most recent changes. Other than that I think this looks good.

What should I do about the error in tests? It adds a new required field, but it is wrapped in an optional struct, so IMO it should be fine right?

ERROR: NoNewRequiredFields: crd/datagathers.insights.openshift.io version/v1alpha1 field/^.spec.storageSpec.persistentVolumeClaimName is new and may not be required

Looking at the failure, it looks like this check is safe to override. I don't have permissions to do this, so it'll be up to Joel to do that when he gives a review.

[everettraven]

Apologies for missing it, but I had totally missed the validation changes to insights/v1alpha1/types_insights.go until now.

Aside from the one comment on the config/v1alpha1 changes those look good to me.

[everettraven]

A couple small things. Other than that, this looks good. Will give approval after they are addressed.

[JoelSpeed]

If you can please apply the suggestions and copy them over to the other version of the API too, then I think this is good to go, thanks

[JoelSpeed]

/override ci/prow/verify-crd-schema

False positives. The required fields it's indicating are within an optional parent struct and therefore are not actually newly required

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed, opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

False positives. The required fields it's indicating are within an optional parent struct and therefore are not actually newly required

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@opokornyy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202503051811.p0.g529099f.assembly.stream.el9.
All builds following this will include this PR.