-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system: use containers/storage
for LCOW
validation
#246
Conversation
@nalind @rhatdan I think |
That logic is still around in the containers/storage pkg/system. Switch it to using that, it's less code to carry around in here. |
LCOW
validation functionscontainers/storage
for LCOW
validation
Newer versions of `github.com/docker/docker` does not supports the LCOW validation functions which imagebuilder uses hence use `github.com/containers/storage/pkg/system`. Alternative solution: refactor imagebuilder to stop using LCOWSupported() Signed-off-by: Aditya R <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@flouthoc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold cancel |
/override "Travis CI - Pull Request" |
@nalind: Overrode contexts on behalf of nalind: Travis CI - Pull Request In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also includes unreleased openshift/imagebuilder#246 to work with the updated docker/docker dependency. And updates some references to newly deprecated docker/docker symbols. [NO NEW TESTS NEEDED] Signed-off-by: Miloslav Trmač <[email protected]>
Newer versions of
github.com/docker/docker
does not supports the LCOW validation functions which imagebuilder uses hence move them to a local package of imagebuilder and drop dependency ongithub.ghproxy.top/docker/docker/pkg/system
Alternative solution: refactor imagebuilder to stop using
LCOWSupported()
Closes and helps in: containers/buildah#4555