CCXDEV-9905: Introduce a new config option for storing archives to persistent volume #1070
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@opokornyy: This pull request references CCXDEV-9905 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: opokornyy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test ci/prow/e2e-gcp-ovn-techpreview |
|
@opokornyy: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-gcp-ovn-techpreview |
1 similar comment
|
/test e2e-gcp-ovn-techpreview |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
opokornyy
force-pushed
the
CCX9905-pv
branch
from
2c8084b to
83dcafd
Compare
opokornyy
force-pushed
the
CCX9905-pv
branch
from
83dcafd to
f0a2873
Compare
openshift-merge-robot
added
the
needs-rebase
This commit adds new field to the config map that allows users to specify PVC that should be used to store archives created by on-demand gathering. Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
This commit implements clean up of archives stored by on-demand gathering in the persistent volume. Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
openshift-merge-robot
removed
the
needs-rebase
opokornyy
force-pushed
the
CCX9905-pv
branch
3 times, most recently
from
dd58324 to
94805e0
Compare
Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test insights-operator-e2e-tests |
This commit is removing the code duplication in a runGather and runaGatherAndUpload functions. Signed-off-by: Ondrej Pokorny <[email protected]>
| mountPath: /data | ||
| persistentVolume: | ||
| claim: | ||
| name: on-demand-gather-pvc |
There was a problem hiding this comment.
why are the two resources here? They shouldn't be here - we don't want the CVO to create them.
|
/retest |
|
@opokornyy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds a new config option for user to specify PVC name where archives produced by on-demand gathering jobs will be stored. It also introduces a cleanup job that removes old archives from the persistent volume.
Categories
Sample Archive
None
Documentation
None
Unit Tests
pkg/controller/periodic/job_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-9905