Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.18] OCPBUGS-51163: Fix bad IPv6 address #1074

Open
wants to merge 2 commits into
base: release-4.18
Choose a base branch
from

Conversation

jmesnil
Copy link
Contributor

@jmesnil jmesnil commented Feb 24, 2025

Let the kube-rbac-proxy listens on 8443 (without specifying the IP address)

In the insights-operator, connect to this port to go through the kube-rbac-proxy

This fixes https://issues.redhat.com/browse/OCPBUGS-51163

I've also cherry-picked a commit for https://issues.redhat.com/browse/OCPBUGS-51164 as it was fixed in master by OCPBUGS-45926: use joinHostPort to fix IPv6 but is also necessary on 4.18 to connect on an IPv6 cluster

Categories

  • Bugfix
  • Backporting

References

https://issues.redhat.com/browse/OCPBUGS-51163
https://issues.redhat.com/browse/OCPBUGS-51164

Upstream PR is #1073

tremes and others added 2 commits February 24, 2025 09:11
Let the kube-rbac-proxy listens on `8443` (without specifying the IP address)

In the insights-operator, connect to this port to go through the kube-rbac-proxy

This fixes https://issues.redhat.com/browse/OCPBUGS-51163

Signed-off-by: Jeff Mesnil <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 24, 2025
@openshift-ci-robot
Copy link
Contributor

@jmesnil: This pull request references Jira Issue OCPBUGS-51163, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-51109 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Let the kube-rbac-proxy listens on 8443 (without specifying the IP address)

In the insights-operator, connect to this port to go through the kube-rbac-proxy

This fixes https://issues.redhat.com/browse/OCPBUGS-51163

I've also cherry-picked a commit for https://issues.redhat.com/browse/OCPBUGS-51164 as it was fixed in master by OCPBUGS-45926: use joinHostPort to fix IPv6 but is also necessary on 4.18 to connect on an IPv6 cluster

Categories

  • Bugfix
  • Backporting

References

https://issues.redhat.com/browse/OCPBUGS-51163
https://issues.redhat.com/browse/OCPBUGS-51164

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 24, 2025
@openshift-ci openshift-ci bot requested review from ncaak and tremes February 24, 2025 08:15
@jmesnil
Copy link
Contributor Author

jmesnil commented Feb 24, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

Copy link

openshift-ci bot commented Feb 24, 2025

@jmesnil: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/84f39f40-f287-11ef-9e00-aa063f638c80-0

@jmesnil
Copy link
Contributor Author

jmesnil commented Feb 24, 2025

/test unit

@tremes
Copy link
Contributor

tremes commented Feb 24, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
Copy link

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmesnil, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2025
@tremes
Copy link
Contributor

tremes commented Feb 24, 2025

/retest

Copy link

openshift-ci bot commented Feb 24, 2025

@jmesnil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tremes
Copy link
Contributor

tremes commented Feb 25, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 25, 2025
@tremes
Copy link
Contributor

tremes commented Mar 12, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Jira Issue OCPBUGS-51163, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-51109 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants