NO-JIRA: refactor gather commands #1076
Conversation
This commit is removing the code duplication in a runGather and runaGatherAndUpload functions. Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
openshift-ci
bot
added
the
approved
|
/retest |
| } | ||
| cancel() | ||
| os.Exit(0) | ||
| } |
There was a problem hiding this comment.
Just for the context. My plan was to remove this when the techpreview is promoted. This corresponds to https://docs.openshift.com/container-platform/4.17/support/remote_health_monitoring/remote-health-reporting-from-restricted-network.html#insights-operator-one-time-gather_remote-health-reporting-from-restricted-network which won't be needed anymore.
|
I didn't run it, but it looks good. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak, opokornyy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
7 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@opokornyy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci-robot
added
the
jira/valid-reference
|
@opokornyy: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This PR implements a new data enhancement to...
Categories
Sample Archive
None
Documentation
None
Unit Tests
None
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References