Additional Compute Machine Pools Rejected By Installer

[dgoodwin]

Version

$ openshift-install version
./bin/openshift-install v0.13.1

Platform (aws|libvirt|openstack):

aws

What happened?

In #1231 support was added for additional compute machine sets, but validation is still blocking this.

FATAL failed to fetch Terraform Variables: failed to load asset "Install Config": invalid "install-config.yaml" file: compute[1].name: Unsupported value: "infra": supported values: "worker"

How to reproduce it (as minimally and precisely as possible)?

Install Config containing:

compute:                                                                                                                                                                                          
- name: worker                                                                                                                                                                                    
  platform:
    aws:                                                                                                                                                                                          
      rootVolume:
        iops: 100
        size: 22
        type: gp2
      type: m4.large
  replicas: 3
- name: infra
  platform:
    aws:
      rootVolume:
        iops: 100
        size: 22
        type: gp2
      type: m4.large
  replicas: 2

[dgoodwin]

Not a 4.0 blocker for us, we already work around by filtering out non-worker pools when generating install config, and not doing so would be broken due to the restrictions around machine set node labels in 4.0.

[abhinavdahiya]

This is now fixed. Installer allows multiple machinepools

/close

[openshift-ci-robot]

@abhinavdahiya: Closing this issue.

In response to this:

This is now fixed. Installer allows multiple machinepools

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[woland7]

I still encounter the same problem as his.

This is my version of the installer:

./openshift-install 4.8.0-0.okd-2021-11-14-052418 built from commit acbb3f8204ed84fc25817a8a8957f97d13868d68 release image quay.io/openshift/okd@sha256:9d977baaf76c5adf95ab5e4f1c0cfc94d5206ca2e437c423bdd633db124a1fe3