baremetal: rename os_image to bootstrap_os_image #2044
Conversation
Unlike other platforms, the baremetal platform uses a different RHCOS boot image for the bootstrap VM (i.e. a qcow image with libvirt) than for all other nodes (i.e. an Ironic-deployed image). Rename the terraform os_image variable to bootstrap_os_image to make it clear that this boot image is only used for the bootstrap VM.
openshift-ci-robot
added
the
size/S
|
/approve |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, cgwalters, hardys, markmc, russellb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@markmc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
For the baremetal platform we require two different bootimages, the QEMU one for the libvirt based bootstrap VM, and the OpenStack one that contains the necessary Ironic config drive support to pass data to ignition. So we rework the Image abstraction by adding a new BootstrapImage type/asset, which returns the same as Image in all cases except for the baremetal platform. This also aligns with the tfvars renamed in openshift#2044 and allows us to pass the rhcos.QEMU image via BootstrapImage to terraform but leaves the OpenStack image URL available for future use to deploy masters via follow-up PRs that implement issue openshift#2060 and also correctly set the worker machineset providerSpec for the baremetal-operator. Related: openshift#2037
Rename the terraform os_image variable to bootstrap_os_image to make it clear that this boot image is only used for the bootstrap VM.
Related to #2037