Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3918: Send service endpoint overrides to CAPG through cluster spec #9528

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

barbacbd
Copy link
Contributor

** Vendoring updates for CAPG upgrades to latest commit.
** Vendor updates for CAPG provider in cluster-api providers
** Match the required set in the CAPG go.mod file to the CAPG required section in their go.mod. This is due to some issues with the CEL library. Without the update the CEL library causes the build to fail on the previous locked version.
** Generated and added the infrastructure components yaml (CRD) for CAPG.
** Set the service endpoints in the CAPG cluster spec. Setting the values here will trigger
CAPG to use overridden endpoints when creating the clients for gcp APIs.

** Vendoring updates for CAPG upgrades to latest commit.
** Match the required set in the CAPG go.mod file to the CAPG required section in their go.mod. This is due to some issues with the CEL library. Without the update the CEL library causes the build to fail on the previous locked version.
…lues here will trigger

CAPG to use overridden endpoints when creating the clients for gcp APIs.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2025

@barbacbd: This pull request references CORS-3918 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

** Vendoring updates for CAPG upgrades to latest commit.
** Vendor updates for CAPG provider in cluster-api providers
** Match the required set in the CAPG go.mod file to the CAPG required section in their go.mod. This is due to some issues with the CEL library. Without the update the CEL library causes the build to fail on the previous locked version.
** Generated and added the infrastructure components yaml (CRD) for CAPG.
** Set the service endpoints in the CAPG cluster spec. Setting the values here will trigger
CAPG to use overridden endpoints when creating the clients for gcp APIs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from barbacbd. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@barbacbd
Copy link
Contributor Author

As a basic example, inside of the 02_gcp-cluster.yaml manifest intended for CAPG we can find

  serviceEndpoints:
    compute: https://my-custom-endpoint.example.com/compute/v1/

Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-heterogeneous cfde8c0 link false /test e2e-aws-ovn-heterogeneous
ci/prow/okd-scos-images cfde8c0 link true /test okd-scos-images
ci/prow/artifacts-images cfde8c0 link true /test artifacts-images
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones cfde8c0 link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-edge-zones cfde8c0 link false /test e2e-aws-ovn-edge-zones
ci/prow/okd-scos-e2e-aws-ovn cfde8c0 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn cfde8c0 link true /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups cfde8c0 link false /test e2e-aws-ovn-shared-vpc-custom-security-groups
ci/prow/e2e-azurestack cfde8c0 link false /test e2e-azurestack
ci/prow/e2e-vsphere-ovn-multi-network cfde8c0 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-azure-ovn-resourcegroup cfde8c0 link false /test e2e-azure-ovn-resourcegroup
ci/prow/azure-ovn-marketplace-images cfde8c0 link false /test azure-ovn-marketplace-images
ci/prow/altinfra-images cfde8c0 link true /test altinfra-images
ci/prow/e2e-azure-default-config cfde8c0 link false /test e2e-azure-default-config
ci/prow/e2e-aws-ovn-single-node cfde8c0 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-azure-ovn-shared-vpc cfde8c0 link false /test e2e-azure-ovn-shared-vpc
ci/prow/terraform-images cfde8c0 link true /test terraform-images
ci/prow/images cfde8c0 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tthvo
Copy link
Contributor

tthvo commented Mar 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants