-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-3918: Send service endpoint overrides to CAPG through cluster spec #9528
base: main
Are you sure you want to change the base?
Conversation
** Vendoring updates for CAPG upgrades to latest commit.
** Match the required set in the CAPG go.mod file to the CAPG required section in their go.mod. This is due to some issues with the CEL library. Without the update the CEL library causes the build to fail on the previous locked version.
…lues here will trigger CAPG to use overridden endpoints when creating the clients for gcp APIs.
@barbacbd: This pull request references CORS-3918 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As a basic example, inside of the serviceEndpoints:
compute: https://my-custom-endpoint.example.com/compute/v1/ |
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
** Vendoring updates for CAPG upgrades to latest commit.
** Vendor updates for CAPG provider in cluster-api providers
** Match the required set in the CAPG go.mod file to the CAPG required section in their go.mod. This is due to some issues with the CEL library. Without the update the CEL library causes the build to fail on the previous locked version.
** Generated and added the infrastructure components yaml (CRD) for CAPG.
** Set the service endpoints in the CAPG cluster spec. Setting the values here will trigger
CAPG to use overridden endpoints when creating the clients for gcp APIs.