Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to v3/ path for glide compatibility #1

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

marun
Copy link

@marun marun commented Apr 1, 2020

The recent move to using a versioned go module name makes the repo incompatible with vendoring with glide. Moving the code to the v3 path used by dependent imports allows glide to update properly.

The recent move to using a versioned go module name makes the repo
incompatible with vendoring with glide. Moving the code to the v3 path
used by dependent imports allows glide to update properly.
@marun
Copy link
Author

marun commented Apr 1, 2020

/hold

Holding until there is a non-master branch to target.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@marun marun changed the base branch from master to origin-4.5-v3.0.0 April 1, 2020 17:05
@marun
Copy link
Author

marun commented Apr 1, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@sttts sttts merged commit 4e06e23 into openshift:origin-4.5-v3.0.0 Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants