-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCS: Supporting Ignition v3 #492
Comments
This card is now out of scope, we should be updating the whole Ignition dependecy to v3 once it comes out and adjust the code. |
Based on some discussion with bgilbert I think we need Ignition to tell us whether the host is FCOS or RHCOS too. |
See also coreos/coreos-assembler#537 |
Also, what makes this issue complex is that we need to support booting from the 4.1.0 bootimages: So the MCS would need to support both. Unless that issue is solved first which would be...nontrivial. |
Personally on this I think we can handle translating a vast majority of what OpenShift customers are doing today. So we'd add a translator into the MCS. |
One thing is, even if we have updated bootimage in place, we'd run into a slight problem if we don't handle both: we'd need to simultaneously update bootimage at the point we "upgrade the cluster to spec3" in one encapsulated update (from my understanding). |
The initial proposal here sketches out a way to handle both old and new bootimages via |
Hm actually I forgot today that the installer is generating the initial "pointer config" user data for AWS which is spec 2 by default too. So one tricky part here is that updating bootimages to a point where they only speak e.g. spec3 and not spec2, we'd also need to update their user data at the same time. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Support has been added as part of the 4.6 release. Closing |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Closing per #492 (comment). |
Related #479
Using "I2" and "I3" for shorthand "Ignition spec v2" and "Ignition spec v3".
We need to support upgrades from 4.0 → 4.1. It feels like we need to simultaneously support I2 and I3 when booting a node. This is related to the MCS (Ignition server). A new master machine boots and the OS speaks I3. Does the MCS have both rendered v2/v3 versions and detect the client version based on e.g.
User-Agent
or something and serve the right one?Or does I3 on the machine support reading I2 and translate?
It feels like a grounding assumption here is that we can reliably do this translation; there's concern about ambiguous/broken cases in I2 but let's assume we don't have those cases in our configs, or if we do we error out much earlier than the MCS (e.g. in the render controller).
The text was updated successfully, but these errors were encountered: