Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-9016 Premigration Checklist find your deployment model needs a *Note* #89749

Open
wants to merge 1 commit into
base: service-mesh-docs-main
Choose a base branch
from

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Mar 6, 2025

OSSM 3.0 GA

OSSM-9016 Premigration Checklist find your deployment model needs a Note

Merge PR to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main

And cherry picked to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s):
GA

Issue:
https://issues.redhat.com/browse/OSSM-9016

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 6, 2025

Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Mar 6, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 6, 2025
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 6, 2025
@stevsmit stevsmit added this to the Continuous Release milestone Mar 6, 2025
@stevsmit
Copy link
Member

stevsmit commented Mar 6, 2025

Note itself looks good. The content its nested under needs a few things (which is beyond the scope of this PR, but something you might wanna consider for the future):

"Find your deployment model" needs an introductory clause before introducing the step (as it currently stands, it jumps into the procedure).

Could use the .Procedure subheading

Should be bulleted (*) as it's a single-step procedure.

But this PR is fine as-is 👍 send 'er to merge review.

@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 6, 2025
@gwynnemonahan
Copy link
Contributor Author

Note itself looks good. The content its nested under needs a few things (which is beyond the scope of this PR, but something you might wanna consider for the future):

"Find your deployment model" needs an introductory clause before introducing the step (as it currently stands, it jumps into the procedure).

Could use the .Procedure subheading

Should be bulleted (*) as it's a single-step procedure.

But this PR is fine as-is 👍 send 'er to merge review.

Cool. Thanks! Yep. There's a refactoring Jira issue already for all the checklists for post GA.

@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants