-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-9016 Premigration Checklist find your deployment model needs a *Note* #89749
base: service-mesh-docs-main
Are you sure you want to change the base?
OSSM-9016 Premigration Checklist find your deployment model needs a *Note* #89749
Conversation
🤖 Thu Mar 06 16:32:26 - Prow CI generated the docs preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label peer-review-needed |
Note itself looks good. The content its nested under needs a few things (which is beyond the scope of this PR, but something you might wanna consider for the future): "Find your deployment model" needs an introductory clause before introducing the step (as it currently stands, it jumps into the procedure). Could use the .Procedure subheading Should be bulleted (*) as it's a single-step procedure. But this PR is fine as-is 👍 send 'er to merge review. |
Cool. Thanks! Yep. There's a refactoring Jira issue already for all the checklists for post GA. |
/label merge-review-needed |
OSSM 3.0 GA
OSSM-9016 Premigration Checklist find your deployment model needs a Note
Merge PR to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
And cherry picked to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0
Version(s):
GA
Issue:
https://issues.redhat.com/browse/OSSM-9016
Link to docs preview:
QE review:
Additional information: