Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opendatahub-io/vllm: remove hardcoded clusters #62492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Mar 6, 2025

No description provided.

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Mar 6, 2025

@tarukumar

@openshift-ci openshift-ci bot requested review from NickLucche and Xaenalt March 6, 2025 15:42
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
Copy link

@tarukumar tarukumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dtrifiro: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-vllm-ibm-dev-images opendatahub-io/vllm presubmit Presubmit changed
pull-ci-opendatahub-io-vllm-ibm-dev-smoke-test opendatahub-io/vllm presubmit Presubmit changed
pull-ci-opendatahub-io-vllm-main-cuda-pr-image-mirror opendatahub-io/vllm presubmit Presubmit changed
pull-ci-opendatahub-io-vllm-main-rocm-pr-image-mirror opendatahub-io/vllm presubmit Presubmit changed
pull-ci-opendatahub-io-vllm-main-smoke-test opendatahub-io/vllm presubmit Presubmit changed
pull-ci-opendatahub-io-vllm-release-images opendatahub-io/vllm presubmit Presubmit changed
pull-ci-opendatahub-io-vllm-release-smoke-test opendatahub-io/vllm presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Mar 6, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@dtrifiro: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2025
Copy link

@tarukumar tarukumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, tarukumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b4ccd01 and 2 for PR HEAD dd13a09 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e0c0a86 and 1 for PR HEAD dd13a09 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD afd555d and 0 for PR HEAD dd13a09 in total

Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

@dtrifiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ordered-prow-config dd13a09 link true /test ordered-prow-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision dd13a09 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants