Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose extractId on RulesEngineService #3728

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Mar 11, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Rkareko
Rkareko previously approved these changes Mar 11, 2025
Signed-off-by: Elly Kitoto <[email protected]>
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.7%. Comparing base (1542bb7) to head (c38e8ed).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3728     +/-   ##
=========================================
- Coverage     37.9%   29.7%   -8.2%     
+ Complexity    1157     899    -258     
=========================================
  Files          287     287             
  Lines        15504   15506      +2     
  Branches      2730    2733      +3     
=========================================
- Hits          5884    4620   -1264     
- Misses        8776   10321   +1545     
+ Partials       844     565    -279     
Flag Coverage Δ
engine 60.7% <100.0%> (-0.1%) ⬇️
geowidget 16.0% <ø> (ø)
quest 11.3% <ø> (-13.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gister/fhircore/engine/rulesengine/RulesFactory.kt 66.3% <100.0%> (+0.1%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rkareko Rkareko added this pull request to the merge queue Mar 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 11, 2025
* Expose extractId on RulesEngineService

Signed-off-by: Elly Kitoto <[email protected]>

* Fix spotless

Signed-off-by: Elly Kitoto <[email protected]>

---------

Signed-off-by: Elly Kitoto <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@Rkareko Rkareko added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 6176659 Mar 11, 2025
5 checks passed
@Rkareko Rkareko deleted the implement-etract-id-rules-engine branch March 11, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants