Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hireling Loosing Updates #1926

Closed
2 of 5 tasks
luancolombo opened this issue Nov 27, 2023 · 0 comments · Fixed by #1935
Closed
2 of 5 tasks

Hireling Loosing Updates #1926

luancolombo opened this issue Nov 27, 2023 · 0 comments · Fixed by #1935
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@luancolombo
Copy link
Contributor

Priority

Medium

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

Voce compra o hireling, depois as skill banker e cook, tudo funciona normal, porem se voce comprar a skill steward, o hireling perde as skills banker e cook. Se voce comprar de novo elas ficam, acredito que esteja acontecendo algo quando compra a steaward que libera o stash

What OS are you seeing the problem on?

Linux, Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luancolombo luancolombo added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 27, 2023
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Nov 27, 2023
@dudantas dudantas mentioned this issue Nov 28, 2023
Merged
2 tasks
dudantas added a commit that referenced this issue Dec 2, 2023
@dudantas @luan
improve: migrate hireling skills and outfits to kv system (#1935)
c18bf44 
Resolves #1926 

Addressed a conflict between hireling system and gamestore subaction IDs, which led to occasional loss of offers and inconvenienced players who had to repurchase the offers. To resolve this issue, we increased the IDs to larger numbers and conducted a minor system overhaul. This involved transitioning to the use of Key-Value (KV) storage, removing obsolete cache code, and enhancing system clarity and performance for a smoother player experience.

Co-authored-by: Luan Santos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve: migrate hireling skills and outfits to kv system opentibiabr/canary
1 participant
@luancolombo