feat: custom pvp system

[sebbesiren]

Description

Created two different systems to modify damage values in PvP.

The first system is damage rate based on levelse. These are controller by three attributes in the config.lua. These have been added to the config.lua.dist.

The second system is damage rates based on vocations. This system is modified using vocations.xml. Added a new tag to the xml named pvp. You can control damage take and dealt per vocation.

All rates are multiplicative so use carefully.

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested

I have tested the system in a test environment.
Tested:

• Damage mitigation from levels
• Damage increase from levels
• Damage mitigation from vocation
• Damage increase from vocation

Test Configuration:

• Server Version: main
• Client: 13.2
• Operating System: Win 11

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sebbesiren]

@dudantas
Is this something that is not wanted? I will try to fix the dependencies until it has been merged.

[dudantas]

@dudantas Is this something that is not wanted? I will try to fix the dependencies until it has been merged.

Yes, it's desirable, I just didn't merge it due to lack of tests and reviews, at the moment I'm busy with some pull requests and I didn't have time to test it.

[sebbesiren]

@dudantas Is this something that is not wanted? I will try to fix the dependencies until it has been merged.

Yes, it's desirable, I just didn't merge it due to lack of tests and reviews, at the moment I'm busy with some pull requests and I didn't have time to test it.

Alright! I will try to updade the PR every now and then.

[SebastianNobbelin]

@dudantas
Updated to new Player pointers so it works again.
Changes looks approved but noone has merged

[sebbesiren]

My bad, commented from another git account :|

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

0.0% Coverage
0.0% Duplication