Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adventurer's stone #1812

Closed
wants to merge 6 commits into from
Closed

Conversation

Leshyah
Copy link
Contributor

@Leshyah Leshyah commented Nov 12, 2023

Description

Adventure stone allowing use out of the specified positions.

Behaviour

Adventure stone is allowing players to use item outside of temple range specified.

Expected

Use only inside of specified positions/temple

Fixes #issuenumber

Removed logic of function to take out z axis.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Tested a few towns and works as intended.

Test Configuration:

  • Server Version: 3.1.1
  • Client: 1321
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Leshyah Leshyah changed the title Adventure stone Fix: Adventure stone Nov 12, 2023
@majestyotbr majestyotbr changed the title Fix: Adventure stone fix: adventurer's stone Nov 12, 2023
@majestyotbr majestyotbr linked an issue Nov 12, 2023 that may be closed by this pull request
5 tasks
@Schiffers
Copy link
Contributor

this script should check if the player are in PZ zone .... to avoid some possibility to use it out of the temple.

@elsongabriel
Copy link
Contributor

PR #1784 fixes it.

@luanluciano93
Copy link
Contributor

A melhor forma de fixar a adventure stone é usando as zones

@luan
Copy link
Contributor

luan commented Nov 12, 2023

A melhor forma de fixar a adventure stone é usando as zones

Seria sim, mas alguem tem que parar pra fazer haha

@elsongabriel elsongabriel removed a link to an issue Nov 12, 2023
5 tasks
@Leshyah Leshyah deleted the adventure-stone branch November 12, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants