fix: issues related to party leadership and leaving a party #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
force-pushed
the
dudantas/fix-party-issues
branch
from
cb9b7ec to
5d8942c
Compare
Resolves #1830
dudantas
force-pushed
the
dudantas/fix-party-issues
branch
from
5d8942c to
e178d45
Compare
|
Kudos, SonarCloud Quality Gate passed! |
elsongabriel
approved these changes
Nov 28, 2023
dudantas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Leadership Transition in Party: Resolved the issue where party leadership was not being passed correctly (Resolves #1830). This fix ensures smooth transition of leadership as intended.
• Leaving Party in Specific Conditions: Addressed a bug where players sometimes couldn't leave a party. The issue was identified in the 'Game::playerLeaveParty' function, which returned prematurely when a player was in a protection zone and in infight mode. This fix includes a check for the protection zone to ensure that players can leave the party as expected.