UCM: Avoid releasing environment strings in library destructor - v1.6.x #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since now libucm.so is not linked with "nodelete", it may be unloaded before it installs malloc hooks. In this case we would not have any environment strings, so no need to release. If it did install hooks, it means the library was aready reopened with RTLD_NODELETE, so no need the strings anyway. This fixes a case where libucm.so was unloaded before hooks were installed, and called clearenv() which removed all environment variables from the program, leading to segfault. Since we are not clearing the environment now, we also cannot release the allocated strings. This is not reported as memory leak by Valgrind, since they are still reachable from the global array of environ strings.
yosefe
changed the title
|
Test PASSed. |
|
Test PASSed. |
hoopoepg
approved these changes
Apr 4, 2019
brminich
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.