-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yggdrasil-jumper: add new package #23072
yggdrasil-jumper: add new package #23072
Conversation
awesome ⚙️ work @one-d-wide |
@one-d-wide -- great work. What's the reason for splitting the Makefiles for yggdrasil and yggdrasil-jumper instead of using the same Makefile to build both? |
Yggdrasil Jumper is optional and logically separate part. And mixing different build processes in one Makefile probably wouldn't benefit readability anyway. |
d076b09
to
916a1de
Compare
Thank you. It should be fixed now. |
916a1de
to
748bfe9
Compare
If so, mark the conversations as resolved. |
Nope, I did not finish it. SoB also requires real name, etc
Dne po 8. 1. 2024 14:46 uživatel Paul Donald ***@***.***>
napsal:
… @BKPepe <https://github.com/BKPepe>
Thank you. It should be fixed now.
If so, mark the conversations as resolved.
—
Reply to this email directly, view it on GitHub
<#23072 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7IDVEV7Q6RYFSJFNG5LK3YNP2CRAVCNFSM6AAAAABBPUNDC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRGAZTQNBWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I replaced it (both in the Makefile and commit details) so CI formalities check should pass. |
You're changing the yggdrasil proper code to accommodate yggdrasil-jumper, so they are evidently connected. My suggestion would be to merge the makefiles, like other packages do, for example acme: https://github.com/openwrt/packages/blob/master/net/acme-acmesh/Makefile, nebula: https://github.com/openwrt/packages/blob/master/net/nebula/Makefile, etc. |
748bfe9
to
9172dd6
Compare
hi @stangri -- the bits of netifd related shell code used by yggdrasil-jumper may be the only option, no? um.. i'm only finding one |
9172dd6
to
43900c3
Compare
@one-d-wide do we fastforward to recheck with ci changes: #23084 |
43900c3
to
dbdb502
Compare
Is this ready? |
@BKPepe Please update your review |
Interesting. Should we revert the recent CI changes here as well and again
require real name? I have not any idea that it was reverted, there. :-(
Dne po 25. 3. 2024 16:52 uživatel Petr Štetiar ***@***.***>
napsal:
… @systemcrash <https://github.com/systemcrash> FYI
***@***.***
<openwrt/actions-shared-workflows@12d9551>
—
Reply to this email directly, view it on GitHub
<#23072 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7IDVGXCJZGYTYG5ZYXSOTY2BB37AVCNFSM6AAAAABBPUNDC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGMZTCOBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
+1 and this time even no PR was made before committing. |
The weasel word there is "should". No discussion or vote raised. |
@1715173329 can you expand a bit on that? There was a PR openwrt/openwrt#14380 and there was a public discussion (1/2024), two times already (2/2023) , see the last thread https://lists.openwrt.org/pipermail/openwrt-devel/2024-January/042063.html leading to this series of pull requests. |
I think, he means that revert in the |
Then evidently the following is erroneous and it should be reverted (revert the revert): |
And this PR can be merged |
I think, @nbd168 wants to do vote, which is done on openwrt-adm, when they are voting about adding new people to the core team. |
I see no desire. Writing "should" two months ago is inconclusive. |
So @one-d-wide I propose that while everyone is really busy trying to get a vote off the ground, in the meantime you adopt some official looking pseudonym, like One D Wide, or John D Wade and force push. Done. |
mips32/xiaomi-4c target bins stun-tcp ............ 1.7M yggdrasil-jumper .... 2.3M Signed-off-by: William Fleurant <[email protected]>
Signed-off-by: William Fleurant <[email protected]>
bc093fd
to
c0c7cc5
Compare
Hi, thank you for the advice. I also resolved a merge conflict so this (along with @BKPepe |
oh please also increase |
Signed-off-by: Remy D. Farley <[email protected]>
c0c7cc5
to
71547f2
Compare
Oops. Done. |
Merged, thank you! |
Description:
Yggdrasil Jumper is independent project that aims to transparently reduce latency of a connection over Yggdrasil network, utilizing NAT traversal to bypass intermediary nodes. It periodically probes for active sessions and automatically establishes direct peerings over internet with remote nodes running Yggdrasil Jumper without requiring firewall or port configuration.
Changes:
yggdrasil-jumper
package.yggdrasil-jumper
withinnetifd
interface script foryggdrasil
.Maintainer: me
Compile tested: x86_64 master
Run tested: x86_64 master