Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yggdrasil-jumper: add new package #23072

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

one-d-wide
Copy link
Contributor

Description:

Yggdrasil Jumper is independent project that aims to transparently reduce latency of a connection over Yggdrasil network, utilizing NAT traversal to bypass intermediary nodes. It periodically probes for active sessions and automatically establishes direct peerings over internet with remote nodes running Yggdrasil Jumper without requiring firewall or port configuration.

Changes:

  • Add yggdrasil-jumper package.
  • Add logic to start/stop yggdrasil-jumper within netifd interface script for yggdrasil.

Maintainer: me
Compile tested: x86_64 master
Run tested: x86_64 master

@wfleurant
Copy link
Member

awesome ⚙️ work @one-d-wide

@stangri
Copy link
Member

stangri commented Jan 6, 2024

@one-d-wide -- great work. What's the reason for splitting the Makefiles for yggdrasil and yggdrasil-jumper instead of using the same Makefile to build both?

@one-d-wide
Copy link
Contributor Author

@one-d-wide -- great work. What's the reason for splitting the Makefiles for yggdrasil and yggdrasil-jumper instead of using the same Makefile to build both?

Yggdrasil Jumper is optional and logically separate part. And mixing different build processes in one Makefile probably wouldn't benefit readability anyway.

@one-d-wide one-d-wide marked this pull request as draft January 7, 2024 11:20
@one-d-wide one-d-wide force-pushed the yggdrasil-jumper-init branch 2 times, most recently from d076b09 to 916a1de Compare January 7, 2024 11:40
@one-d-wide one-d-wide marked this pull request as ready for review January 7, 2024 11:46
@one-d-wide
Copy link
Contributor Author

@BKPepe

Thank you. It should be fixed now.

@one-d-wide one-d-wide force-pushed the yggdrasil-jumper-init branch from 916a1de to 748bfe9 Compare January 8, 2024 12:19
@systemcrash
Copy link
Contributor

@BKPepe

Thank you. It should be fixed now.

If so, mark the conversations as resolved.

@BKPepe
Copy link
Member

BKPepe commented Jan 8, 2024 via email

@one-d-wide
Copy link
Contributor Author

Nope, I did not finish it. SoB also requires real name, etc

I replaced it (both in the Makefile and commit details) so CI formalities check should pass.

@stangri
Copy link
Member

stangri commented Jan 8, 2024

@one-d-wide -- great work. What's the reason for splitting the Makefiles for yggdrasil and yggdrasil-jumper instead of using the same Makefile to build both?

Yggdrasil Jumper is optional and logically separate part. And mixing different build processes in one Makefile probably wouldn't benefit readability anyway.

You're changing the yggdrasil proper code to accommodate yggdrasil-jumper, so they are evidently connected.

My suggestion would be to merge the makefiles, like other packages do, for example acme: https://github.com/openwrt/packages/blob/master/net/acme-acmesh/Makefile, nebula: https://github.com/openwrt/packages/blob/master/net/nebula/Makefile, etc.

@one-d-wide one-d-wide force-pushed the yggdrasil-jumper-init branch from 748bfe9 to 9172dd6 Compare January 9, 2024 14:48
@wfleurant
Copy link
Member

You're changing the yggdrasil proper code to accommodate yggdrasil-jumper, so they are evidently connected.

hi @stangri -- the bits of netifd related shell code used by yggdrasil-jumper may be the only option, no? um..

i'm only finding one PKG_SOURCE_URL per Makefile. its late, may be i am missing something... sorry im missing a solution, ttyl 💤

@one-d-wide one-d-wide force-pushed the yggdrasil-jumper-init branch from 9172dd6 to 43900c3 Compare January 10, 2024 17:26
@wfleurant
Copy link
Member

@one-d-wide do we fastforward to recheck with ci changes: #23084

@one-d-wide one-d-wide force-pushed the yggdrasil-jumper-init branch from 43900c3 to dbdb502 Compare January 23, 2024 13:12
@wfleurant
Copy link
Member

@BKPepe on your review, please. identity / signature OK in CI #23084

@systemcrash
Copy link
Contributor

Is this ready?

@systemcrash
Copy link
Contributor

@BKPepe Please update your review

@systemcrash
Copy link
Contributor

ping @ynezz @981213

@systemcrash
Copy link
Contributor

@BKPepe Please update your review

ping @ynezz @981213

@ynezz
Copy link
Member

ynezz commented Mar 25, 2024

@systemcrash FYI openwrt/actions-shared-workflows@12d9551

@BKPepe
Copy link
Member

BKPepe commented Mar 25, 2024 via email

@1715173329
Copy link
Member

+1 and this time even no PR was made before committing.

@systemcrash
Copy link
Contributor

The weasel word there is "should". No discussion or vote raised.

@ynezz
Copy link
Member

ynezz commented Mar 25, 2024

and this time even no PR was made before committing.

@1715173329 can you expand a bit on that? There was a PR openwrt/openwrt#14380 and there was a public discussion (1/2024), two times already (2/2023) , see the last thread https://lists.openwrt.org/pipermail/openwrt-devel/2024-January/042063.html leading to this series of pull requests.

@BKPepe
Copy link
Member

BKPepe commented Mar 25, 2024

I think, he means that revert in the actions-shared-workflows repository.

@systemcrash
Copy link
Contributor

and there was a public discussion (1/2024)

Then evidently the following is erroneous and it should be reverted (revert the revert):

@systemcrash FYI openwrt/actions-shared-workflows@12d9551

@systemcrash
Copy link
Contributor

And this PR can be merged

@BKPepe
Copy link
Member

BKPepe commented Mar 25, 2024

evidently the following is erroneou

I think, @nbd168 wants to do vote, which is done on openwrt-adm, when they are voting about adding new people to the core team.

@systemcrash
Copy link
Contributor

I think, @nbd168 wants to do vote, which is done on openwrt-adm, when they are voting about adding new people to the core team.

I see no desire. Writing "should" two months ago is inconclusive.

@systemcrash
Copy link
Contributor

So @one-d-wide I propose that while everyone is really busy trying to get a vote off the ground, in the meantime you adopt some official looking pseudonym, like One D Wide, or John D Wade and force push. Done.

mips32/xiaomi-4c target bins
stun-tcp ............ 1.7M
yggdrasil-jumper .... 2.3M

Signed-off-by: William Fleurant <[email protected]>
@one-d-wide one-d-wide force-pushed the yggdrasil-jumper-init branch 3 times, most recently from bc093fd to c0c7cc5 Compare March 28, 2024 18:09
@one-d-wide
Copy link
Contributor Author

Hi, thank you for the advice. I also resolved a merge conflict so this (along with luci PR) should be ready to be merged.

@BKPepe
Please update your review, it is displayed as "changes requested" at the moment.

@1715173329
Copy link
Member

oh please also increase PKG_RELEASE for yggdrasil.

@one-d-wide one-d-wide force-pushed the yggdrasil-jumper-init branch from c0c7cc5 to 71547f2 Compare April 2, 2024 12:30
@one-d-wide
Copy link
Contributor Author

oh please also increase PKG_RELEASE for yggdrasil.

Oops. Done.

@1715173329 1715173329 merged commit 69a5a80 into openwrt:master Apr 2, 2024
12 checks passed
@1715173329
Copy link
Member

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants