CONTRIBUTING.md: Clarify pull request requirements #23190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecammit
force-pushed
the
contributing_pr_clarification
branch
from
67fad27 to
45d61c1
Compare
stokito
reviewed
Jan 30, 2024
ecammit
force-pushed
the
contributing_pr_clarification
branch
from
45d61c1 to
a346187
Compare
stokito
approved these changes
Jan 30, 2024
mhei
approved these changes
Jan 30, 2024
|
ecammit
force-pushed
the
contributing_pr_clarification
branch
from
a346187 to
df231f7
Compare
@BKPepe Fixed. |
BKPepe
reviewed
Feb 3, 2024
CONTRIBUTING.md
Outdated
| - Include Signed-off-by tag in the commit comments. See: [Sign your | ||
| work](https://openwrt.org/submitting-patches#sign_your_work) | ||
| - Author and sign-off must match and be a real name or known identity and | ||
| a real email address. Github private email addresses will not be accepted. |
There was a problem hiding this comment.
Suggested change
| a real email address. Github private email addresses will not be accepted. | |
| a real email address. GitHub private email addresses will not be accepted. |
There was a problem hiding this comment.
Resolved Github -> GitHub in my new work as well as 6 other references in the file. Also updated Sourceforge -> SourceForge, because I happened to see it when I was resolving one of the GitHub instances.
Corrects the commit subject being referred to as a "description" and links the official OpenWrt patch submission standards for commit messages. Adds additional notes about real names and emails being required. Also fixes the capitalization of GitHub and SourceForge. Signed-off-by: Timothy Ace <[email protected]>
ecammit
force-pushed
the
contributing_pr_clarification
branch
from
df231f7 to
0493841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @champtar
Compile tested: not applicable here
Run tested: not applicable here
Description:
As a new contributor to this repository, the language in
CONTRIBUTING.mdwas unclear and resulted in some unnecessary back and forth with reviewers. I believe these clarifications should assist future contributors.