Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spdk: missing accel_crypto_key_destroy #143

Closed
glimchb opened this issue Feb 9, 2023 · 1 comment · Fixed by #145
Closed

spdk: missing accel_crypto_key_destroy #143

glimchb opened this issue Feb 9, 2023 · 1 comment · Fixed by #145

Comments

@glimchb
Copy link
Member

glimchb commented Feb 9, 2023

https://github.com/opiproject/opi-spdk-bridge/blob/main/pkg/server/middleend.go

we only create key and never remove it...

probably also in UpdateEncryptedVolume need to remove/destroy key before creating a new one ?
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this issue Feb 9, 2023
@glimchb
spdk: middle: add AccelCryptoKeyDestroy
10adf35 
Fixes opiproject#143

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb mentioned this issue Feb 9, 2023
Merged
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this issue Feb 9, 2023
@glimchb
spdk: middle: add AccelCryptoKeyDestroy
2a7cc6e 
Fixes opiproject#143

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb
Copy link
Member Author

glimchb commented Feb 9, 2023

waiting on spdk/spdk#2904

glimchb added a commit to glimchb/opi-spdk-bridge that referenced this issue Feb 10, 2023
@glimchb
spdk: middle: add AccelCryptoKeyDestroy
f52c228 
Fixes opiproject#143

Signed-off-by: Boris Glimcher <[email protected]>
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this issue Feb 10, 2023
@glimchb
spdk: middle: add AccelCryptoKeyDestroy
8f7b99d 
Fixes opiproject#143

Signed-off-by: Boris Glimcher <[email protected]>
glimchb added a commit that referenced this issue Feb 10, 2023
@glimchb
spdk: middle: add AccelCryptoKeyDestroy
25e3a12 
Fixes #143

Signed-off-by: Boris Glimcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spdk: middle: add AccelCryptoKeyDestroy glimchb/opi-spdk-bridge
1 participant
@glimchb