Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDK: bump release to 23.01 (jan) LTS #121

Merged
merged 3 commits into from
Feb 8, 2023
Merged

SPDK: bump release to 23.01 (jan) LTS #121

merged 3 commits into from
Feb 8, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Feb 1, 2023

Signed-off-by: Boris Glimcher [email protected]

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #121 (1a38334) into main (6c940d2) will increase coverage by 2.33%.
The diff coverage is 41.50%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   49.83%   52.16%   +2.33%     
==========================================
  Files           4        4              
  Lines        1194     1340     +146     
==========================================
+ Hits          595      699     +104     
- Misses        580      625      +45     
+ Partials       19       16       -3     
Impacted Files Coverage Δ
pkg/server/middleend.go 66.30% <41.50%> (-5.62%) ⬇️
pkg/server/frontend.go 58.72% <0.00%> (+3.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glimchb
Copy link
Member Author

glimchb commented Feb 1, 2023

failed on

2023-02-01T02:27:09.1969210Z �[36mopi-spdk-client_1  |�[0m 2023/02/01 02:27:07 could not create CRYPTO device: rpc error: code = Unknown desc = bdev_crypto_create: json response error: No key was found

see doc https://spdk.io/doc/jsonrpc.html#rpc_bdev_crypto_create

spdk error

2023-02-01T02:27:09.2101342Z �[32mspdk_1             |�[0m [2023-02-01 02:27:07.524630] vbdev_crypto_rpc.c: 136:rpc_bdev_crypto_create: *WARNING*: "crypto_pmd" parameters is obsolete and ignored
2023-02-01T02:27:09.2101893Z �[32mspdk_1             |�[0m [2023-02-01 02:27:07.524741] accel_sw.c: 750:sw_accel_crypto_key_init: *ERROR*: Only AES_XTS cipher is supported
2023-02-01T02:27:09.2102397Z �[32mspdk_1             |�[0m [2023-02-01 02:27:07.524816] vbdev_crypto_rpc.c: 163:rpc_bdev_crypto_create: *ERROR*: No key was found

@glimchb glimchb force-pushed the spdk branch 4 times, most recently from e16d1e6 to 824f017 Compare February 1, 2023 03:24
@glimchb
Copy link
Member Author

glimchb commented Feb 1, 2023

failed on

2023-02-01T02:27:09.1969210Z �[36mopi-spdk-client_1  |�[0m 2023/02/01 02:27:07 could not create CRYPTO device: rpc error: code = Unknown desc = bdev_crypto_create: json response error: No key was found

see doc https://spdk.io/doc/jsonrpc.html#rpc_bdev_crypto_create

spdk error

2023-02-01T02:27:09.2101342Z �[32mspdk_1             |�[0m [2023-02-01 02:27:07.524630] vbdev_crypto_rpc.c: 136:rpc_bdev_crypto_create: *WARNING*: "crypto_pmd" parameters is obsolete and ignored
2023-02-01T02:27:09.2101893Z �[32mspdk_1             |�[0m [2023-02-01 02:27:07.524741] accel_sw.c: 750:sw_accel_crypto_key_init: *ERROR*: Only AES_XTS cipher is supported
2023-02-01T02:27:09.2102397Z �[32mspdk_1             |�[0m [2023-02-01 02:27:07.524816] vbdev_crypto_rpc.c: 163:rpc_bdev_crypto_create: *ERROR*: No key was found

fixed by using new API, need to fix the unittests now...

@glimchb glimchb marked this pull request as ready for review February 8, 2023 21:25
@glimchb glimchb requested a review from a team as a code owner February 8, 2023 21:25
@glimchb glimchb closed this Feb 8, 2023
@glimchb glimchb reopened this Feb 8, 2023
@glimchb glimchb changed the title SPDK: bump release to 23.01 (jan) SPDK: bump release to 23.01 (jan) LTS Feb 8, 2023
@glimchb glimchb merged commit 6134ccb into main Feb 8, 2023
@glimchb glimchb deleted the spdk branch February 8, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants