Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdk: use pb.EncryptionType instead of hard-coded #144

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Feb 9, 2023

Fixes #123

Signed-off-by: Boris Glimcher [email protected]

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #144 (6b87e8c) into main (65d75cb) will decrease coverage by 0.41%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   49.67%   49.27%   -0.41%     
==========================================
  Files           4        4              
  Lines        1226     1236      +10     
==========================================
  Hits          609      609              
- Misses        599      608       +9     
- Partials       18       19       +1     
Impacted Files Coverage Δ
pkg/server/middleend.go 62.75% <14.28%> (-3.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glimchb
Copy link
Member Author

glimchb commented Feb 9, 2023

fails on

opi-spdk-server_1  | 2023/02/09 21:44:17 Sending to SPDK: {"jsonrpc":"2.0","id":53,"method":"accel_crypto_key_create","params":{"cipher":"AES_XTS_128","key":"0123456789abcdef0123456789abcdef","key2":"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa","name":"super_key"}}
opi-spdk-server_1  | 2023/02/09 21:44:17 Received from SPDK: {"id":53,"error":{"code":-32602,"message":"failed to create DEK, rc -22"},"result":false}
opi-spdk-server_1  | 2023/02/09 21:44:17 error: accel_crypto_key_create: json response error: failed to create DEK, rc -22

due to

spdk_1             | [2023-02-09 21:44:17.857110] accel_sw.c: 750:sw_accel_crypto_key_init: *ERROR*: Only AES_XTS cipher is supported

note AES_XTS_128 vs AES_XTS

@glimchb glimchb force-pushed the glimchb-patch-1 branch 4 times, most recently from 6da870c to 8511197 Compare February 9, 2023 23:18
@glimchb glimchb marked this pull request as ready for review February 9, 2023 23:18
@glimchb glimchb requested a review from a team as a code owner February 9, 2023 23:18
@glimchb glimchb merged commit 519c5c9 into main Feb 9, 2023
@glimchb glimchb deleted the glimchb-patch-1 branch February 9, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instead of hard-coded AES_XTS/AES_CBC use in.EncryptedVolume.Cipher.String()
1 participant