Folder restructure #178
Folder restructure #178
Conversation
split to several packages: - frontend - middleend - backend This will help importing this library from other projects TODOs: - remove some code dup in tests - split to more files like nvme vs virtio Signed-off-by: Boris Glimcher <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 48.72% 43.76% -4.97%
==========================================
Files 4 4
Lines 1250 1250
==========================================
- Hits 609 547 -62
- Misses 622 688 +66
+ Partials 19 15 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Boris Glimcher <[email protected]>
glimchb
added
the
Merge Candidate
| } | ||
|
|
||
| log.Printf("SPDK mockup Server: got : %s", string(data)) | ||
| log.Printf("SPDK mockup Server: snd : %s", spdk) |
| pb.RegisterNullDebugServiceServer(s, &server.Server{}) | ||
| pb.RegisterAioControllerServiceServer(s, &server.Server{}) | ||
| pb.RegisterMiddleendServiceServer(s, &server.Server{}) | ||
| pb.RegisterFrontendNvmeServiceServer(s, &frontend.Server{}) |
There was a problem hiding this comment.
Would it be sufficient to create only one frontend.Server instance and pass it into RegisterFrontendNvmeServiceServer, RegisterFrontendVirtioBlkServiceServer etc?
| "testing" | ||
|
|
||
| "google.golang.org/protobuf/proto" |
There was a problem hiding this comment.
nit, but I'd organize this with the other protobuf import below
There was a problem hiding this comment.
I'll run goimport tool to auto-sort this
|
@artek-koltun I will merge this one and address your comments in a new PR that I already have pending. |
split to several packages:
This will help importing this library from other projects
TODOs:
Signed-off-by: Boris Glimcher [email protected]