-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ide-extension): message extraction #372
Conversation
Your Render PR Server URL is https://inlang-website-pr-372.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cflvij9mbjslejj2rt0g. |
in #133 the following will be done:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aweeeesome to see the ide extension working again!
Open questions
Should the callback be used as "name" and "id" be removed from `replacementOptions?
The developer experience could be improved by showing the result of the action instead of an "id".
I extracted a message and was taken back for a few seconds when I got prompted whether I want to "extract a message as JSX or JS string". Answering the question leads to multiple seconds of thinking. The question collides with the result I want to achieve e.g. "reference the message in a t() function that is wrapped in curly brackets" and not "extract as JSX string".
Proposal
- Show the result of the
callback
as a replacement option instead of the id/name in the extract message prompt. - Remove
id
from the replacement option type but keep the replacement option as an object to allow the later introduction ofid
,name
, or other properties.
CleanShot.2023-02-15.at.17.38.21.mp4
Great proposal. I've implemented this: Kooha-2023-02-16-15-09-33.webm |
LGTM. If ready for merge, go ahead and merge this PR :) |
Open tasks:
unwrap()
)