This repository was archived by the owner on May 15, 2024. It is now read-only.
Make subject optional #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aviral Takkar <[email protected]>
shizhMSFT
reviewed
Jun 15, 2022
specs-go/v1/manifest.go
Outdated
| @@ -28,7 +28,7 @@ type Manifest struct { | |||
|
|
|||
| // Subject is an optional reference to any existing manifest within the repository. | |||
| // When specified, the artifact is said to be dependent upon the referenced subject. | |||
| Subject Descriptor `json:"subject"` | |||
| Subject Descriptor `json:"subject,omitempty"` | |||
There was a problem hiding this comment.
How about this?
Suggested change
| Subject Descriptor `json:"subject,omitempty"` | |
| Subject *Descriptor `json:"subject,omitempty"` |
There was a problem hiding this comment.
Do you consider to update other optional string properties in the spec?
Signed-off-by: Aviral Takkar <[email protected]>
This was referenced Jun 21, 2022
|
/cc @michaelb990 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.