Removing the additional duplicate sub-directory from sanitize_path() #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a fix to #100. |
This was referenced Sep 21, 2023
saketjajoo
force-pushed
the
pull-custom-path
branch
from
6796cac to
3ae616b
Compare
|
A few requests as tests are running (and I'm switching back and forth to other work):
|
The existing implementation adds an additional sub-directory with the same name when an image is pulled and is stored explicitly to a custom output directory. This happens because the "test_path" variable appends "path" to "base_dir" wherein the "path" variable itself is base_dir + filename. This commit fixes this problem. Signed-off-by: saketjajoo <[email protected]>
saketjajoo
force-pushed
the
pull-custom-path
branch
from
3ae616b to
a23f2e4
Compare
|
It seems that Python's black library recently made a change to validate the data type of the "exclude" key in the pyproject.toml file. Now the value for "exclude" must be a single-quoted string (for regex matches). I've added a second commit to this PR to address this. |
…ntax for data types. This commit also formats the test_provider.py file. Signed-off-by: saketjajoo <[email protected]>
saketjajoo
force-pushed
the
pull-custom-path
branch
from
2b95507 to
d9b8ccf
Compare
vsoch
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation adds an additional sub-directory with the same name when an image is pulled and is stored explicitly to a custom output directory. This happens because the "test_path" variable appends "path" to "base_dir" wherein the "path" variable itself is base_dir + filename. This commit fixes this problem.