Docker optional dependency #28
Conversation
we currently are just using it for login and finding configs, and since osx on conda does not have it (and we want to support it) it makes sense to have docker be optional, meaning we fall back to manual ways to do the same thing. I am leaving it as an extra variant for now in case someone prefers using docker, however if we have confidence it is not needed it can be removed entirely. Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
docker-optional-dependency
branch
from
6f24938 to
524e22c
Compare
|
Awesome! I think the regular OS X 64 on conda-forge has it, just the osx-arm64 (M1) chip not yet. |
|
Ah gotcha! Also I was testing newer versions of docker (on Linux/Ubuntu) and the function behavior wasn't consistent (e.g., updating broke some functions) so that is what first incentivized me to want to remove it / make it optional. Likely we will need a user that has a more complicated docker config setup to know if/what is missing. |
Signed-off-by: vsoch <[email protected]>
|
Thank you! I think we will need an admin approval (ping @sajayantony!) before the merge is allowed (and I'm not too keen on clicking the "merge without waiting for requirements to be met" box. When this goes in, I'm planning to release after #32 is merged since it fixes some bugs with respect to pushing to GitHub packages. Then we will have a new release for conda-forge too! |
Signed-off-by: vsoch <[email protected]>
|
@wolfv I've just triggered a release, so I'll follow up on conda-forge to update the recipe to not require docker. |
We currently are just using it for login and finding configs, and since osx on conda does not have it (and we want to support it) it makes sense to have docker be optional, meaning we fall back to manual ways to do the same thing. I am leaving it as an extra variant for now in case someone prefers using docker, however if we have confidence it is not needed it can be removed entirely.
See conda-forge/oras-py-feedstock#1 and ping @wolfv