Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing redundant getting started docs #39

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

vsoch
Copy link
Contributor

@vsoch vsoch commented Jun 19, 2022

The main getting started docs are provided (as a single markdown file) here, and that s deployed to oras-www. The remaining
content here is about contributing / development, and I am also adding links between them so it is easy to find the right one

Signed-off-by: vsoch [email protected]

the main getting started docs are provided (as a single markdown file) here, and that
is deployed to oras-www. The remaining content here is about contributing / development,
and I am also adding links between them so it is easy to find the right one

Signed-off-by: vsoch <[email protected]>
steps, and please open an issue if functionality is missing.
steps, and please [open an issue](https://github.com/oras-project/oras-py/issues) if
functionality is missing. More detailed developer examples can also be found on the
[Oras Python](https://oras-project.github.io/oras-py/) page hosted alongside the repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it will be better to combine Oras Python to the official website? People might be easier to find ORAS-python from a unified documentation portal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed you are working on migrating the docs from oras-py to the ORAS website. Let me know if you need assistance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the entire point of this PR - the file here 1_python.md is grabbed and deployed to the official site! It should be done after these two are merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kills two birds with one stone because the corresponding docs are alongisde the respective code (e.g., as I'm updating the library here I can update them) but then nightly they are grabbed and deployed to oras-www. Here is the page here deployed there: https://oras.land/client_libraries/1_python/ and the PR here is removing the redundant docs from here.

your own custom interactions.
your own custom interactions. The main getting started docs can be found on
`oras.land Python's page <https://oras.land/client_libraries/1_python/>`_ and
the developer user guide (and more detailed examples) can be found here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developer user guide => developer guide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to say "developer user" - a developer user is not a user of the client, but a developer developing with it. I guess maybe it sounds weird, but in my mind:

  • developer: sort of referring to a main maintainer (will likely respond to issues / fix bugs)
  • developer user: using someone else's SDK, etc, (will likely open issues / report bugs)
  • user: typically someone that is just, for example, running the client (but not developing anything)

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added small tips. The overall looks good!

@vsoch
Copy link
Contributor Author

vsoch commented Jun 23, 2022

Thank you @FeynmanZhou ! Let me know if you have other questions or suggestions for changes.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsoch vsoch merged commit 7bceecc into main Jun 23, 2022
@vsoch vsoch deleted the remove-redundant-docs branch June 23, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant docs
3 participants