Minor fixes and support for Subject #89
Conversation
dev-zero
commented
Jun 28, 2023
dev-zero
commented
- registry: disable cookies
- schema: the subject element consists is an object (if present)
- provider: add argument to pass a subject
|
@dev-zero this looks good - a few tweaks:
|
|
@vsoch do you mind if I "fix" pre-commit to install the tools isolated rather than trying to run locally? |
|
... and while being at it, switch from flake8 to ruff? |
|
I think I’d prefer keeping the current linting for now - at least for this PR. I’m open to changes but it’s out of scope for the work here. |
|
done |
|
I found yet another issue when working on/with Subject: the referrer API gives back digests for the referenced manifests, but |
The specs are changing and the registries differ in implementations, so definitely there could be missing pieces. Shall we finish up the work here and work on this in another scoped PR? Either way, you'll still need to bump the version and update the CHANGELOG.md as I mentioned earlier. Thanks! |
dev-zero
force-pushed
the
bugfix/subject
branch
2 times, most recently
from
e82608a to
d681083
Compare
|
done, @vsoch |
|
Also - if formatting keeps failing I'd be happy to push a commit for you (just let me know). |
Required to properly interact with some registries like Harbor which are otherwise trying to set and validate CSRF headers which are not passed along against hidden cookie values. This chainreaction starts with oras-py accepting the sid cookie. Signed-off-by: Tiziano Müller <[email protected]>
Signed-off-by: Tiziano Müller <[email protected]>
Signed-off-by: Tiziano Müller <[email protected]>
Not doing so makes it impossible to pull() an artifact via digest (and simply passing in a digest as a tag will confuse the regex parser up to the point it will try to fetch the blobs from docker.io Signed-off-by: Tiziano Müller <[email protected]>
Signed-off-by: Tiziano Müller <[email protected]>
|
Ok, merged and rebased @vsoch |
