-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: transfer cl position to new owner #6623
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
efc7fba
transer cl position
czarcas7ic 3c0dbd4
Auto: update go.mod after push to adam/transfer-position-cl that modi…
invalid-email-address bca1533
changelog
czarcas7ic dff2315
remove commented out logic
czarcas7ic 231ada1
Update CHANGELOG.md
czarcas7ic 5cfe3bf
add godoc and test for ParseUint64SliceToString
czarcas7ic 198cf74
add godoc
czarcas7ic 21195ee
add incentives and spread rewards to message server test
czarcas7ic 39bac77
expand message server test
czarcas7ic 07be722
further expand test
czarcas7ic 4346b86
godoc
czarcas7ic 2528e96
Auto: update go.mod after push to adam/transfer-position-cl that modi…
invalid-email-address 0dc9123
use helper methods
czarcas7ic febb5d4
modify array diff method
czarcas7ic 16e9829
Auto: update go.mod after push to adam/transfer-position-cl that modi…
invalid-email-address 920b1a4
address test
czarcas7ic 1b04c86
last test fix
czarcas7ic 5d6f510
Update x/concentrated-liquidity/client/cli/tx.go
czarcas7ic bb936a1
Update osmoutils/compare.go
czarcas7ic 9cd487e
rename all uses
czarcas7ic 3ab50f1
sort the result, add tests for both sorted and unsorted
czarcas7ic 56eea8d
extend tests
czarcas7ic 0254345
unrelated lint
czarcas7ic 57fe3ca
Merge branch 'main' into adam/transfer-position-cl
czarcas7ic b17bd2c
add testing invariants comment to TestTransferPositions
czarcas7ic c96b505
add why actual amount should be less than expected
czarcas7ic c9ecd14
Auto: update go.mod after push to adam/transfer-position-cl that modi…
invalid-email-address bb9706c
regen docs
czarcas7ic 2ac0230
comment explaining trasferPosition in proto
czarcas7ic ad2b3c3
add fixed gas consumption
czarcas7ic fd24b80
fix scaling gas charge and add parser test case
AlpinYukseloglu e68d661
Auto: update go.mod after push to adam/transfer-position-cl that modi…
invalid-email-address 04a3a68
remove incorrect comment
czarcas7ic 710bd89
Merge branch 'main' into adam/transfer-position-cl
czarcas7ic a6d8092
tidy osmomath
czarcas7ic 0b8367a
transfer random position
czarcas7ic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to sort the result before returning because map iterations are non-deterministic.
Please also make sure that unsorting is caught by tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good call, sorted the results and added both sorted and unsorted tests 3ab50f1