-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix alloyed prices breakage with candidate route optimization #377
fix alloyed prices breakage with candidate route optimization #377
Conversation
Warning Review failedThe pull request is closed. WalkthroughRecent changes introduce new configurations for Go test settings, enhancements to the documentation with the addition of Alloyed Transmuter Pools, and notable updates for handling these alloyed assets in the liquidity maps. Functions related to pool data and candidate routes have been updated for better clarity and efficiency, along with extensive testing checks to validate alloyed denominations handling and liquidity adjustments. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
Actions performedReview triggered.
|
4658dac
into
roman/data-253-candidaterouteopt-introduce-dynamic-min-liquidity-into
… e2e flakiness & alloyed bug (#376) * feat: introduce dynamic min liquidity into pricing (fix e2e flakiness) * fixes * comment * e2e test flakiness * fix test * fix alloyed prices breakage with candidate route optimization (#377) * fix alloyed prices breakage with candidate route optimization * update docs * unit test and docs * clean up * clean up * remove test * comment * update spec
* feat: introduce dynamic min liquidity into pricing (fix e2e flakiness) * fixes * comment * e2e test flakiness * fix test * fix alloyed prices breakage with candidate route optimization (#377) * fix alloyed prices breakage with candidate route optimization * update docs * unit test and docs * clean up * clean up * remove test * comment * update spec * feat: Reimplement & test GetCandidateRoute algorithm * lint
This PR formalizes the treatment of alloyed LP shares relative to pool balances and denoms.
It modifies the ingest logic per the new documented invariants and unit tests the newly added method.
Testing
Summary by CodeRabbit
New Features
Documentation
Refactor
Tests