Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix typo in branch protections details #4270

Merged
merged 2 commits into from
Aug 1, 2024
Merged

📖 Fix typo in branch protections details #4270

merged 2 commits into from
Aug 1, 2024

Conversation

martincostello
Copy link
Contributor

What kind of change does this PR introduce?

Fix typo in branch protections details message.

What is the current behavior?

Messages such as the following are emitted in scorecard reports:

Warn: 'stale review dismissal' is disable on branch 'main'

What is the new behavior (if this is a feature change)?**

Grammar in message is fixed to use the correct text:

- Warn: 'stale review dismissal' is disable on branch 'main'
+ Warn: 'stale review dismissal' is disabled on branch 'main'
  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

Fix typo in branch protections details.

Fix typo in branch protections details message.

Signed-off-by: Martin Costello <[email protected]>
@martincostello martincostello requested a review from a team as a code owner July 31, 2024 12:10
@martincostello martincostello requested review from justaugustus and raghavkaul and removed request for a team July 31, 2024 12:10
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

(Note: the e2e failure is something else and will need to be resolved by maintainers separately in a different PR)

@spencerschrock spencerschrock changed the title 🐛 Fix typo 📖 Fix typo in branch protections details Aug 1, 2024
@spencerschrock spencerschrock enabled auto-merge (squash) August 1, 2024 18:23
@spencerschrock spencerschrock merged commit 8f9d27b into ossf:main Aug 1, 2024
39 checks passed
@martincostello martincostello deleted the patch-1 branch August 1, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants