Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Fix progress reporting #277

Closed
cgwalters opened this issue Apr 4, 2022 · 0 comments · Fixed by #282
Closed

Fix progress reporting #277

cgwalters opened this issue Apr 4, 2022 · 0 comments · Fixed by #282

Comments

@cgwalters
Copy link
Member

OK one ugly thing with current import APIs is that our progress reporting is basically broken:

  • We only handle it for unencapsulation, not layered paths
  • We don't provide useful information on which layer we're handling
  • We operate on the uncompressed size, for which we don't know the total
  • (related to above) We don't provide the total size
@cgwalters cgwalters mentioned this issue Apr 4, 2022
Merged
cgwalters added a commit to cgwalters/ostree-rs-ext that referenced this issue Apr 11, 2022
@cgwalters
container: Add support for layer fetch notifications
2d547fa 
Part of ostreedev#277
When we only supported one big ostree tarball, our current
single u64 progress notification was OK.  But clients (including our
CLI) really want more dynamic progress notifications.

This adds support for an optional channel that receives started/finished
notifications for layers.  Note that the client *must* read from
this channel if they request it. The channel is not lossy.
@cgwalters cgwalters mentioned this issue Apr 11, 2022
Merged
cgwalters added a commit to cgwalters/ostree-rs-ext that referenced this issue Apr 12, 2022
@cgwalters
container: Add support for layer fetch notifications
7794ada 
Part of ostreedev#277
When we only supported one big ostree tarball, our current
single u64 progress notification was OK.  But clients (including our
CLI) really want more dynamic progress notifications.

This adds support for an optional channel that receives started/finished
notifications for layers.  Note that the client *must* read from
this channel if they request it. The channel is not lossy.
@cgwalters cgwalters mentioned this issue May 24, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

container: Precise byte-level progress reporting cgwalters/ostree-rs-ext
1 participant
@cgwalters