Allow ignoring hidden files, respecting .gitignore and git exclude #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrmiguel
changed the title
|
This is awesome :D One suggestion: I think splitting the options for git and hidden files would be valuable, maybe we could just copy |
Good point! I'll try adding that soon :D |
marcospb19
reviewed
Nov 10, 2021
| @@ -42,6 +42,10 @@ pub enum Subcommand { | |||
| /// The resulting file. Its extensions can be used to specify the compression formats. | |||
| #[clap(required = true, value_hint = ValueHint::FilePath)] | |||
| output: PathBuf, | |||
|
|
|||
| /// If set, `ouch` will *not* compress hidden files or files ignored through .gitignore or .ignore | |||
There was a problem hiding this comment.
This will appear in the --help message, so it should be a bit shorter, suggestion:
/// Ignore hidden files
I think that we should have another flag, -i/--ignore for .gitignore and .ignore files.
|
Reopened and merged at #245. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170