Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh pull-request won't start with flags in core.editor #98

Merged
merged 1 commit into from
Nov 26, 2013

Conversation

owenthereal
Copy link
Owner

For example,

[core]
  editor = vim --noplugin

This gives me:
2013/11/26 13:32:04 fatal: command not found: /usr/bin/vim --noplugin

While this works fine

[core]
  editor = vim

Meanwhile, hub works with both cases.

@owenthereal
Copy link
Owner

I'll look into this soon

@owenthereal owenthereal merged commit 79a9543 into master Nov 26, 2013
@owenthereal owenthereal deleted the fix_git_editor_path branch November 26, 2013 15:17
@owenthereal
Copy link
Owner

Fixed in 79a9543. Please upgrade. I'll make a build in a sec

@raine
Copy link
Author

raine commented Nov 26, 2013

Thanks for the fix.

Raine

On 26.11.2013, at 17.19, Jingwen Owen Ou [email protected] wrote:

Fixed in 79a9543. Please upgrade. I'll make a build in a sec


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants