Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 convert explorers from TSV to YML #4080

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Mar 6, 2025

ref: #4072

  • Remove etl.explorer_helpers (it was not in use)
  • Move etl.explorer to etl.collections.explorer_tsv, since it is an interface for TSV-based explorers. etl.collections.explorers is a more general interact, which also deals with YAML-based explorers.
  • Rename Explorer (formerly in etl.explorer) as ExplorerTSV (now in etl.collections.explorer_tsv).

Future, related:

  • Add support for display for indicators
    • old TSV → new dataclass
    • new dataclass → TSV (only indicator-based)
  • Test tools in Population explorer: Working on this in https://github.com/owid/etl/pull/4095/files
  • Put simple functions in place to do migration
  • Add check to just allow migration when possible:
    • CSV-based with ETL-generated
    • Indicator-based

@owidbot
Copy link
Contributor

owidbot commented Mar 6, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-feature-explorers-tsv-yml

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2025-03-11 17:21:05 UTC
Execution time: 20.74 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants