Collection of work to improve efficiency of app #12081
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| @@ -924,6 +923,9 @@ void Folder::startSync() | |||
| Q_ASSERT(isReady()); | |||
| Q_ASSERT(_folderWatcher); | |||
|
|
|||
| if (!isReady() || !_folderWatcher) | |||
| return; | |||
There was a problem hiding this comment.
agreed to have a log statement here ....
| @@ -984,6 +986,9 @@ void Folder::startSync() | |||
| void Folder::setDirtyNetworkLimits() | |||
| { | |||
| Q_ASSERT(isReady()); | |||
| if (!isReady()) | |||
| return; | |||
There was a problem hiding this comment.
agreed to have a log statement here ....
src/gui/folder.cpp
Outdated
| @@ -1365,6 +1369,8 @@ QString FolderDefinition::spaceId() const | |||
| // we might call the function to check for the id | |||
| // anyhow one of the conditions needs to be true | |||
| Q_ASSERT(_webDavUrl.isValid() || !_spaceId.isEmpty()); | |||
| if (!_webDavUrl.isValid() || _spaceId.isEmpty()) | |||
There was a problem hiding this comment.
agreed to have a log statement here ....
…derMan named migrateFolderDefinition improved loading from config to only save the extracted FolderDefintions if they were migrated started prepping for deeper cuts related to Folder::saveToSettings, plus overhaul of impl and uses of FolderMan::addFolderFromFolderWizardResult and addFolderFromWizard
|
Client crashed when squish tries to run client. Crash stracktrace and client logs are here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will include some refactoring work to improve the efficiency of the app. First task is to reduce the number of calls to QSettings::sync(), and possibly refactor the update behavior of the FolderStatusModel