Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation failure without "serde" feature #131

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

cbbowen
Copy link
Contributor

@cbbowen cbbowen commented Sep 30, 2024

Compilation currently fails without the "serde" feature enabled because the use of #[serde(...)] isn't conditioned on the feature being enabled. This PR uses cfg_attr to do so similar to the Serialize and Deserialize derives.

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2024

CLA assistant check
All committers have signed the CLA.

@goulart-paul goulart-paul changed the base branch from main to develop January 6, 2025 22:30
@goulart-paul goulart-paul merged commit de6ce7b into oxfordcontrol:develop Jan 6, 2025
1 check passed
@goulart-paul
Copy link
Member

Apologies for the slow merge, and thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants